Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade ethereumjs util #10886

Merged
merged 1 commit into from
Apr 16, 2021
Merged

upgrade ethereumjs util #10886

merged 1 commit into from
Apr 16, 2021

Conversation

brad-decker
Copy link
Contributor

@brad-decker brad-decker commented Apr 14, 2021 •
edited
Loading

Changes

  1. Destructuring import as the module system in ethereum-js-util changed.
  2. sha3 -> keccak
  3. Conversion of strings to buffers before sending to keccak.
  4. Upgrade of library itself
  5. Extra isHex check in settings page so that it doesn't attempt to check isValidAddress with (0xsettings) URL path.

@metamaskbot
Copy link
Collaborator

Builds ready [08503ca]
Page Load Metrics (634 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint48755973
domContentLoaded42583363211656
load42683463411756
domInteractive42583263211656

@brad-decker brad-decker marked this pull request as ready for review April 15, 2021 15:00
@brad-decker brad-decker requested a review from a team as a code owner April 15, 2021 15:00
NiranjanaBinoy
NiranjanaBinoy previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing self-requested a review April 15, 2021 18:35
darkwing
darkwing previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Well done @brad-decker !

@brad-decker
Copy link
Contributor Author

@NiranjanaBinoy @darkwing -- rebased to address conflicts. no other changes made.

@metamaskbot
Copy link
Collaborator

Builds ready [a659966]
Page Load Metrics (600 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint45675563
domContentLoaded3387675999948
load3407686009948
domInteractive3387665999948

@brad-decker brad-decker merged commit d1f8171 into develop Apr 16, 2021
@brad-decker brad-decker deleted the upgrade-ethereumjs-util branch April 16, 2021 15:05
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@NiranjanaBinoy NiranjanaBinoy NiranjanaBinoy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brad-decker @metamaskbot @darkwing @NiranjanaBinoy